Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-79658 New pattern to Preserve Case ( underscore separated variables) #79660

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@skprabhanjan
Copy link
Contributor

commented Aug 22, 2019

@roblourens and @rebornix , Here is the implementation to handle underscore characters as well to fix #79658 ( As mentioned implemented it as two disjoint sets of replacement )
Please review this and let me know , Thanks :)

PS : if you feel the request itself is not a valid one then feel free to close it :) ( I thought underscore was also useful in some places )

@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

@roblourens and @rebornix
Sorry , any updates on this ? ( I will close this if this is not a legit requirement )

Copy link
Member

left a comment

LGTM, will let @rebornix review too

@roblourens roblourens added this to the September 2019 milestone Sep 5, 2019
@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@rebornix , Any updates on this ?
Did you get a chance to review this ?

@roblourens

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

He's on paternity leave now but I think it's fine, I'll merge it.

@roblourens roblourens merged commit ad5e820 into microsoft:master Sep 11, 2019
1 of 2 checks passed
1 of 2 checks passed
VS Code #20190823.120 failed
Details
license/cla All CLA requirements met.
Details
@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@roblourens , sorry I did not know he was on leave and thanks for merging it 😁

@ArturoDent

This comment has been minimized.

Copy link

commented Sep 24, 2019

See my comment here: #79525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.