Fix #79428 - add "$WORKSPACE_FOLDER" for snippet #79764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrieken I added tests. |
jrieken
requested changes
Sep 4, 2019
| @@ -272,13 +274,31 @@ export class WorkspaceBasedVariableResolver implements VariableResolver { | |||
| } | |||
|
|
|||
| if (isSingleFolderWorkspaceIdentifier(workspaceIdentifier)) { | |||
| return path.basename(workspaceIdentifier.path); | |||
| if (variable.name === 'WORKSPACE_NAME') { | |||
There was a problem hiding this comment.
this repeated-if-else is a little ugly, can't you change it be two methods, like _resolveWorkspaceName and _resoveWorkspacePath?
There was a problem hiding this comment.
sure, I can do it later.
hunghw
commented
Sep 11, 2019
| @@ -272,13 +274,31 @@ export class WorkspaceBasedVariableResolver implements VariableResolver { | |||
| } | |||
|
|
|||
| if (isSingleFolderWorkspaceIdentifier(workspaceIdentifier)) { | |||
| return path.basename(workspaceIdentifier.path); | |||
| if (variable.name === 'WORKSPACE_NAME') { | |||
There was a problem hiding this comment.
sure, I can do it later.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new snippet variable
WORKSPACE_FOLDER.