Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cmd+F key in problems view robbed by find in editor #80068

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@ypresto
Copy link
Contributor

commented Aug 29, 2019

Cmd+F (Ctrl+F) in Problems View should focus filter, but actually it opens find widget in editor.
This PR increases weight of keybinding to fix it.
Also add focus filter keybinding in MarkerPanelFilterFocusContextKey to keep from focusing find widget (same approach as terminal.contribution.ts).

@sandy081

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

Fixes issue #80207

@sandy081 sandy081 self-requested a review Sep 2, 2019
@sandy081 sandy081 added this to the September 2019 milestone Sep 2, 2019
Copy link
Member

left a comment

LGTM

@sandy081 sandy081 merged commit 43e6d83 into microsoft:master Sep 2, 2019
1 of 2 checks passed
1 of 2 checks passed
VS Code queued
Details
license/cla All CLA requirements met.
@ypresto ypresto deleted the ypresto:fix-markers-key-weight branch Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.