Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #80014 #80071

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@dgozman
Copy link
Contributor

commented Aug 29, 2019

No description provided.

@dgozman dgozman marked this pull request as ready for review Aug 29, 2019
@dgozman

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

@isidorn Could you please take a look? This is my first PR to vscode, so any contributing suggestions are more than welcome!

@isidorn isidorn added this to the September 2019 milestone Aug 30, 2019
@isidorn

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

@dgozman thanks a lot for providing a PR. This looks great and captures the approach I had in mind. I left one minor comment inline in the code.
Did you build vscode with these changes and verifed that #80014 gets fixed?

@dgozman dgozman force-pushed the dgozman:fix-80014 branch from 5f56032 to 54b3b7f Aug 30, 2019
Copy link
Contributor Author

left a comment

Did you build vscode with these changes and verifed that #80014 gets fixed?
Sure, my repro case works as expected with this change.

src/vs/workbench/contrib/debug/common/debug.ts Outdated Show resolved Hide resolved
@isidorn

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

Looks great, thanks a lot for this PR.
Merging in 🎉

@isidorn isidorn merged commit 55bec33 into microsoft:master Sep 2, 2019
1 of 2 checks passed
1 of 2 checks passed
VS Code #20190830.54 failed
Details
license/cla All CLA requirements met.
Details
@dgozman

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.