Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildSnapPackage: use the default snapcraft target #80217

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@sergiusens
Copy link
Contributor

commented Sep 2, 2019

Use the default snap target for snapcraft to create the snap (build is an
intermediate lifecycle step).

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

Use the default snap target for snapcraft to create the snap (build is an
intermediate lifecycle step).

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@joaomoreno

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Hi @sergiusens, thanks for this. Does it address any specific issue or you just think it's best we run the default target instead of explicitly running build?

@joaomoreno joaomoreno added the snap label Sep 3, 2019
@sergiusens

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Sorry for taking so long to get back to you, this is just a default target thing.

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

No worries, thanks for this.

@joaomoreno joaomoreno added this to the September 2019 milestone Sep 10, 2019
@joaomoreno joaomoreno merged commit 51334d5 into microsoft:master Sep 10, 2019
1 of 2 checks passed
1 of 2 checks passed
VS Code #20190902.125 failed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.