Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #26659. #80227

Merged
merged 2 commits into from Sep 10, 2019

Conversation

@txava
Copy link
Contributor

commented Sep 2, 2019

Clicking on a local file link will open up the editor on a separate editor group (new or reuse existing one) as seen in the video (For some reason the mouse pointer is not being recorded but still can an idea on what's happening)

Fixes #26659

Clicking on a  local file link will open up the editor on a separate editor group (new or reuse existing one).
@mjbvz mjbvz added this to the September 2019 milestone Sep 3, 2019
Copy link
Contributor

left a comment

Thanks for taking a look at this. I think we should add a setting to control this behavior, similar to the existing markdown.preview.openMarkdownLinks setting. The default would be top open markdown links in the current group

Let me know if you have any questions about this

…group

Adding "markdown.editor.openMarkdownLinks" setting to specify where
links to markdown files should open (current editor group by default).
Copy link

left a comment

I'm proud of who I have become.

@txava

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

@mjbvz Thanks for the review.
Just pushed another commit which adds a setting to control the behavior.

Cheers,
Sal

@mjbvz mjbvz merged commit c307d73 into microsoft:master Sep 10, 2019
2 checks passed
2 checks passed
VS Code #20190910.3 succeeded
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Thanks! Will be in the next VS Code insiders build and scheduled to be in VS Code 1.39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.