Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve template literals support to match TS #80234

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@IllusionMH
Copy link
Contributor

IllusionMH commented Sep 2, 2019

PR microsoft/TypeScript#32064 brings several improvements to how template literals are treated.

Currently I'm working on improving handling of template literals in various TS services and will update this PR if any changes needed to support updated functionality.

Current list of changes:

  1. Trigger completions when user types ` in the same way as when they type ' or " (as per suggestion in microsoft/TypeScript#32064 (comment))
@IllusionMH IllusionMH mentioned this pull request Sep 2, 2019
7 of 7 tasks complete
@IllusionMH IllusionMH force-pushed the IllusionMH:better-tempate-literal-support branch from eb42f0f to a458b7d Nov 4, 2019
@IllusionMH IllusionMH marked this pull request as ready for review Nov 4, 2019
@IllusionMH

This comment has been minimized.

Copy link
Contributor Author

IllusionMH commented Nov 4, 2019

Ooops, forgot about this one. 🤦‍♂

PR microsoft/TypeScript#32064 is merged and after investigation across other services there is nothing that needs updates on VS Code side.

It was planned for VS Code version shipped with 3.7 but I understand that missed feature freeze. so can be added with #83935.

@mjbvz mjbvz added this to the November 2019 milestone Nov 4, 2019
@mjbvz mjbvz merged commit a188b90 into microsoft:master Nov 4, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191104.53 succeeded
Details
license/cla All CLA requirements met.
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Nov 4, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.