Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorter expand/shrink selection shortcuts on mac #80491

Merged
merged 2 commits into from Sep 6, 2019

Conversation

@solomatov
Copy link
Contributor

commented Sep 6, 2019

No description provided.

@solomatov

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

It seems that the build check on linux failed with an error unrelated to this change. What should be done about it?

@jrieken jrieken self-assigned this Sep 6, 2019
@jrieken jrieken added this to the September 2019 milestone Sep 6, 2019
mac: {
primary: KeyMod.CtrlCmd | KeyMod.WinCtrl | KeyMod.Shift | KeyCode.RightArrow,
secondary: [KeyMod.WinCtrl | KeyMod.Shift | KeyCode.RightArrow],
},

This comment has been minimized.

Copy link
@jrieken

jrieken Sep 6, 2019

Member

This is only for mac, right? How about the other platforms?

This comment has been minimized.

Copy link
@solomatov

solomatov Sep 6, 2019

Author Contributor

On other platforms, they are good enough: the primary shortcut is KeyMod.Shift | KeyMod.Alt | KeyCode.LeftArrow, which is the same length as Mac.

This comment has been minimized.

Copy link
@jrieken

jrieken Sep 6, 2019

Member

Ah, makes sense. Thanks for clarifying

@jrieken
jrieken approved these changes Sep 6, 2019
mac: {
primary: KeyMod.CtrlCmd | KeyMod.WinCtrl | KeyMod.Shift | KeyCode.RightArrow,
secondary: [KeyMod.WinCtrl | KeyMod.Shift | KeyCode.RightArrow],
},

This comment has been minimized.

Copy link
@jrieken

jrieken Sep 6, 2019

Member

Ah, makes sense. Thanks for clarifying

@jrieken jrieken merged commit 8f6a073 into microsoft:master Sep 6, 2019
1 of 2 checks passed
1 of 2 checks passed
VS Code queued
Details
license/cla All CLA requirements met.
@solomatov solomatov deleted the solomatov:expand-shrink-shortcuts branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.