Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activation of linters on unopened files caused by markdown plugin #80506

Merged
merged 11 commits into from Sep 11, 2019

Conversation

@solomatov
Copy link
Contributor

commented Sep 7, 2019

Here's the issue: #50874

Solution:

  • Bug was caused by invocations of vscode.workspace.openTextDocument during indexing process
  • I create a document index which maintains a map from uri to TextDocument
  • When we need a document, we
    • Check whether it's already loaded and if it is, we use loaded document
    • Otherwise we read it through fs API
…markdown extension opening TextDocuments during indexing
@msftclas

This comment has been minimized.

Copy link

commented Sep 7, 2019

CLA assistant check
All CLA requirements met.

solomatov added 2 commits Sep 7, 2019
@solomatov solomatov changed the title Fix activation of a large number of linters caused by markdown plugin Fix activation of linters on unopened files caused by markdown plugin Sep 7, 2019
@mjbvz mjbvz added this to the September 2019 milestone Sep 9, 2019
@solomatov

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

@mjbvz Do you have any other things to fix in the review?

Copy link
Contributor

left a comment

This is going in the correct direction but want to make sure we don't make the more common uses of TableOfContentsProvider more inefficient. Let me know if you have any questions about the comments

solomatov added 4 commits Sep 11, 2019
code review comments
@solomatov

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

@mjbvz It seems that I fixed all your suggestions. Thanks for them, they made the code better and much shorter.

solomatov added 2 commits Sep 11, 2019
@mjbvz mjbvz merged commit 5db460d into microsoft:master Sep 11, 2019
2 checks passed
2 checks passed
VS Code #20190911.17 succeeded
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Thanks for the PR and for the changes! Looks good to me.

This will be in the next VS Code insiders build and is scheduled to ship with VS Code 1.39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.