Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: add assets verbatim #80585

Merged
merged 8 commits into from Sep 10, 2019

Conversation

@sergiusens
Copy link
Contributor

commented Sep 9, 2019

Providing the desktop files in snap/gui will have snapcraft copy over
those assets into the snaps meta/gui verbatim.

Addtionally, add a leading ${SNAP} to the Icon entry which was also
moved to snap/gui for the "package" to have an icon by default
(which is important when sideloading).

Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com

Providing the desktop files in snap/gui will have snapcraft copy over
those assets into the snaps meta/gui verbatim.

Addtionally, add a leading ${SNAP} to the Icon entry which was also
moved to snap/gui for the "package" to have an icon by default
(which is important when sideloading).

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
@msftclas

This comment has been minimized.

Copy link

commented Sep 9, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

sergiusens sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@joaomoreno joaomoreno self-assigned this Sep 10, 2019
@joaomoreno joaomoreno added the snap label Sep 10, 2019
@joaomoreno joaomoreno added this to the September 2019 milestone Sep 10, 2019
joaomoreno added 7 commits Sep 10, 2019
@joaomoreno

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

@sergiusens Thanks for pushing us in the right direction. I had to push a few more commits on top, but everything looks like it works properly!

@joaomoreno joaomoreno merged commit 19526f4 into microsoft:master Sep 10, 2019
5 of 7 checks passed
5 of 7 checks passed
VS Code queued
Details
license/cla Contributor License Agreement is not signed yet.
Details
VS Code Build #20190910.12 succeeded
Details
VS Code (Compile) Compile succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (LinuxSnap) LinuxSnap succeeded
Details
VS Code (Mooncake) Mooncake succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.