Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Disposable[] with DisposableStore #80661

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@solomatov
Copy link
Contributor

commented Sep 10, 2019

See #74250 for details.

@mjbvz mjbvz added this to the September 2019 milestone Sep 10, 2019
@mjbvz mjbvz self-assigned this Sep 10, 2019
@@ -38,7 +38,7 @@ class MessageWidget {
private readonly _relatedBlock: HTMLDivElement;
private readonly _scrollable: ScrollableElement;
private readonly _relatedDiagnostics = new WeakMap<HTMLElement, IRelatedInformation>();
private readonly _disposables: IDisposable[] = [];
private readonly _disposables: DisposableStore = new DisposableStore();

This comment has been minimized.

Copy link
@mjbvz

mjbvz Sep 10, 2019

Contributor

[nit] Don't need to duplicate the type here

@mjbvz mjbvz merged commit db9733d into microsoft:master Sep 10, 2019
2 checks passed
2 checks passed
VS Code #20190910.165 succeeded
Details
license/cla All CLA requirements met.
@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2019

Thanks!

@solomatov solomatov deleted the solomatov:more-disposables branch Sep 12, 2019
@solomatov solomatov restored the solomatov:more-disposables branch Sep 12, 2019
@solomatov solomatov deleted the solomatov:more-disposables branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.