Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DebugSession.loadSource work for non-cached sources, see #79228 #80669

Merged
merged 2 commits into from Sep 12, 2019

Conversation

@dgozman
Copy link
Contributor

commented Sep 10, 2019

When source with passed uri has not been seen before, and didn't end up DebugSession.sources map, existing code throws an exception by constructing an invalid uri. Using Source.getEncodedDebugData helps.

@weinand Could you please take a look? Attempting to fix the issue with debug URIs. Thank you!

When source with passed uri has not been seen before, and didn't end up DebugSession.sources map,
existing code throws an exception by constructing an invalid uri. Using Source.getEncodedDebugData helps.
Copy link
Member

left a comment

looks good (and much simpler) to me.

@weinand weinand merged commit db4102a into microsoft:master Sep 12, 2019
1 of 2 checks passed
1 of 2 checks passed
VS Code in progress
Details
license/cla All CLA requirements met.
@weinand

This comment has been minimized.

Copy link
Member

commented Sep 12, 2019

@dgozman thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.