Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Disposable[] with DisposableStore #80684

Merged
merged 3 commits into from Oct 15, 2019

Conversation

@solomatov
Copy link
Contributor

solomatov commented Sep 11, 2019

See #74250 for details.

solomatov added 2 commits Sep 11, 2019
@aeschli

This comment has been minimized.

Copy link
Contributor

aeschli commented Sep 11, 2019

See #74250 (comment)

Please note that its up to the code feature owners to decide whether they want to switch to DisposableStore.
So please first check first with them (e.g. use blame to figure out who does most of the work in the given area) and keep the PR limited to a feature.

@solomatov

This comment has been minimized.

Copy link
Contributor Author

solomatov commented Sep 11, 2019

@aeschli This PR is limited to a feature. There's a protected field in one of the classes, so I had to update descendants as well.

@roblourens roblourens added this to the October 2019 milestone Sep 26, 2019
@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Oct 14, 2019

Sorry it took so long to get to this. I can merge it if you can resolve the conflicts.

@roblourens roblourens merged commit 385bf0f into microsoft:master Oct 15, 2019
2 checks passed
2 checks passed
VS Code #20191015.11 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.