Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add touch events to minimap #81097

Merged
merged 4 commits into from Sep 30, 2019

Conversation

@Rophuine
Copy link
Contributor

commented Sep 18, 2019

Fixes #47771
Add touch events to minimap to allow scrolling the viewport using tap/drag on touchscreens.
Implemented using gestures - initially done using raw touch events but gestures seemed to add some nice inertia etc. and is idiomatic to the code base.
When you tap anywhere on the minimap it scrolls to that location.
As you drag it moves the viewport.
Similar behaviour to Visual Studio.
Testing in maximized & restored views including after resize and window move.

Lionell Pack added 2 commits Sep 18, 2019
@msftclas

This comment has been minimized.

Copy link

commented Sep 18, 2019

CLA assistant check
All CLA requirements met.

Lionell Pack
@kieferrm kieferrm requested a review from alexandrudima Sep 18, 2019
@alexandrudima alexandrudima added this to the September 2019 milestone Sep 25, 2019
@alexandrudima alexandrudima merged commit 4ca2a27 into microsoft:master Sep 30, 2019
1 of 2 checks passed
1 of 2 checks passed
VS Code in progress
Details
license/cla All CLA requirements met.
Details
@alexandrudima

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.