Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A readOnly editor doesn't honor readonly in the textArea #81394

Merged
merged 3 commits into from Sep 30, 2019

Conversation

@ElasticPencil
Copy link

commented Sep 24, 2019

Fixing an issue where a readOnly editor will still activate the input controls on mobile devices.

The underlying cause is the TextArea element is missing the readonly attribute.
This change applies the readonly attribute when the editor is created or the configuration changes to editor.readOnly === true.

… controls on mobile devices.

The underlying cause is the TextArea element is missing the readonly attribute.
This change applies the readonly attribute when the editor is created or the configuration changes to editor.readOnly === true.
@alexandrudima alexandrudima merged commit 531522b into microsoft:master Sep 30, 2019
1 of 2 checks passed
1 of 2 checks passed
VS Code in progress
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.