Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow for optional chain token in completions #81402

Merged
merged 1 commit into from Sep 25, 2019

Conversation

@rbuckton
Copy link
Member

commented Sep 24, 2019

Fixes an issue where completions for non-identifier member names are ignored because the TypeScriptCompletionItemProvider was only looking for the preceding . token and did not include the optional chain token ?.. This resulted in an incorrect filter text when applied to the list of available completions:

image

With this change, the completion list is filtered properly:

image

@rbuckton

This comment has been minimized.

Copy link
Member Author

commented Sep 24, 2019

cc: @mjbvz

@mjbvz mjbvz added this to the September 2019 milestone Sep 25, 2019
@mjbvz mjbvz merged commit 340f7be into microsoft:master Sep 25, 2019
1 of 2 checks passed
1 of 2 checks passed
VS Code #20190924.63 failed
Details
license/cla All CLA requirements met.
@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.