Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for touch events on the suggest widget (Fixes #78984) #81442

Merged
merged 5 commits into from Sep 26, 2019

Conversation

@davidreis97
Copy link
Contributor

commented Sep 25, 2019

Fixes #78984

Works by implementing a onListTap event listener for a tap GestureEvent on the SuggestWidget class. The new listener runs the same code as the onListMouseDown event listener.

If you think it's best to extract the onListTap() and onListMouseDown() functions in order to avoid duplicated code please let me know, I didn't do it right away since it's just a couple lines of code.

davidreis97 added 4 commits Sep 25, 2019
Copy link
Member

left a comment

Changes LGTM and works great 👍

Let's not duplicate code and name the function onListMouseDownOrTap.

@octref octref added this to the September 2019 milestone Sep 26, 2019
…ap in SuggestWidget
@davidreis97

This comment has been minimized.

Copy link
Contributor Author

commented Sep 26, 2019

Thanks for the feedback, refactored as suggested, using a union type of IListMouseEvent and IListGestureEvent as the type of the argument of the new function.

@octref
octref approved these changes Sep 26, 2019
@octref octref merged commit effbd9b into microsoft:master Sep 26, 2019
2 checks passed
2 checks passed
VS Code #20190926.73 succeeded
Details
license/cla All CLA requirements met.
@octref

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

🚢 it. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.