Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 81779 Preserve Case Hyphen and Underscore replacement issues #81781

Merged
merged 3 commits into from Oct 1, 2019

Conversation

@skprabhanjan
Copy link
Contributor

commented Oct 1, 2019

@roblourens , This fixes #81779 .
I have changed the ordering of condition checking ( first we check for hyphen and underscore variables so that we don't return initially itself and miss replace foo_Bar to newfoo_newbar )

CC : @ArturoDent , This fixes the comment you had raised.

@@ -7,20 +7,19 @@ import * as strings from './strings';

export function buildReplaceStringWithCasePreserved(matches: string[] | null, pattern: string): string {

This comment has been minimized.

Copy link
@roblourens

roblourens Oct 1, 2019

Member

I don't understand why this function takes a string[] then only looks at the first element?

This comment has been minimized.

Copy link
@skprabhanjan

skprabhanjan Oct 1, 2019

Author Contributor

The initial implementation was like this only , I guess it was some parameter passing issue ( Needed to send a string[] , We can fix it at the source and change the type here)
I am not sure about this , I can look it in detail and change it if required .
PS : I can raise one more issue to fix this parameter confusion.

@roblourens roblourens added this to the September 2019 milestone Oct 1, 2019
@roblourens roblourens merged commit 5bd8022 into microsoft:master Oct 1, 2019
2 checks passed
2 checks passed
VS Code #20191001.10 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.