Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-81729 Preserve case in Search and Replace isn't working when I use group substitution #81858

Merged
merged 2 commits into from Oct 26, 2019

Conversation

@skprabhanjan
Copy link
Contributor

skprabhanjan commented Oct 2, 2019

@roblourens , This was not touched upon when preserve case was implemented , I have changed it to make it work for group substitution also . The gist of the change is that instead of returning text.replace(this._regExp, this.pattern); we return text.replace(this._regExp, this.buildReplaceString(match, preserveCase));

NOTE : I have changed test methods to the standard used in other functions to make it look cleaner as this was getting pretty messy , and existing test methods would cover this fix test cases

#81729

@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

skprabhanjan commented Oct 14, 2019

@roblourens , Any updates on this ?

Copy link
Member

roblourens left a comment

Thanks!

@roblourens roblourens merged commit 334b636 into microsoft:master Oct 26, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191025.13 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.