Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press `space` key on a disabled button should not trig click event. #81975

Merged
merged 1 commit into from Oct 5, 2019

Conversation

@youngyou
Copy link
Contributor

youngyou commented Oct 4, 2019

Press space key on a disabled button should not trig click event.

Press `space` key on a disabled button should not trig click event
@Tyriar
Tyriar approved these changes Oct 5, 2019
Copy link
Member

Tyriar left a comment

Nice find 👍

@Tyriar Tyriar added this to the October 2019 milestone Oct 5, 2019
@Tyriar Tyriar merged commit ff09b48 into microsoft:master Oct 5, 2019
2 checks passed
2 checks passed
VS Code #20191004.15 succeeded
Details
license/cla All CLA requirements met.
@Tyriar Tyriar self-assigned this Oct 5, 2019
@youngyou youngyou deleted the youngyou:patch-1 branch Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.