Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: remove unused config settings #82019

Merged
merged 1 commit into from Oct 16, 2019

Conversation

@bmalehorn
Copy link
Contributor

bmalehorn commented Oct 6, 2019

searchRipgrep.enable and search.runInExtensionHost are no longer
used. A code search for searchRipgrep and runInExtensionHost shows
no matches.

While they were originally used to determine if searches should be run
with ripgrep, they were later replaced with search.useRipgrep. That
setting itself is now deprecated and does the same thing as
search.usePCRE2 (so it actually doesn't disable ripgrep), but at least
it does something.

So delete these settings that are beyond deprecation - they do nothing.

cc @roblourens

`searchRipgrep.enable` and `search.runInExtensionHost` are no longer
used. A code search for `searchRipgrep` and `runInExtensionHost` shows
no matches.

While they were originally used to determine if searches should be run
with ripgrep, they were later replaced with `search.useRipgrep`. That
setting itself is now deprecated and does the same thing as
`search.usePCRE2` (so it actually doesn't disable ripgrep), but at least
it does something.

So delete these settings that are beyond deprecation - they do nothing.
@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 6, 2019

CLA assistant check
All CLA requirements met.

@roblourens roblourens added this to the October 2019 milestone Oct 6, 2019
@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Oct 6, 2019

Thanks. I think search.runInExtensionHost might be disconnected on accident. It's not really useful for users but I might want it for testing in the future. Will have to dig into the history.

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Oct 16, 2019

Yeah I might bring it back later but don't have any reason to do that now so I'll merge this, thanks.

@roblourens roblourens merged commit e576dc7 into microsoft:master Oct 16, 2019
2 checks passed
2 checks passed
VS Code #20191006.1 succeeded
Details
license/cla All CLA requirements met.
Details
@bmalehorn bmalehorn deleted the bmalehorn:remove-search-configs branch Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.