Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Image preview should not zoom on first click if unfocused #82074

Merged
merged 15 commits into from Oct 14, 2019

Conversation

@MartinBrathen
Copy link
Contributor

MartinBrathen commented Oct 8, 2019

@mjbvz I believe this should solve issue #81877

@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 8, 2019

CLA assistant check
All CLA requirements met.

MartinBrathen
@MartinBrathen

This comment has been minimized.

Copy link
Contributor Author

MartinBrathen commented Oct 8, 2019

Pressed the "Update branch" button, now test are not passing, will try to fix somehow.

extensions/image-preview/media/main.js Outdated Show resolved Hide resolved
extensions/image-preview/media/main.js Show resolved Hide resolved
extensions/image-preview/src/preview.ts Show resolved Hide resolved
MartinBrathen and others added 2 commits Oct 9, 2019
MartinBrathen
@MartinBrathen

This comment has been minimized.

Copy link
Contributor Author

MartinBrathen commented Oct 9, 2019

I removed an unnecessary state variable.

In this branch I removed the 'mousedown' listener and the usage of message passing as well. Sadly it introduces a bug where the user has to click twice if the image preview is not focused by clicking on the preview. I do not currently know of a way to check how the preview was focused.

@MartinBrathen MartinBrathen requested a review from mjbvz Oct 10, 2019
MartinBrathen and others added 7 commits Oct 11, 2019
@mjbvz mjbvz added this to the October 2019 milestone Oct 14, 2019
@mjbvz mjbvz merged commit 9048856 into microsoft:master Oct 14, 2019
2 checks passed
2 checks passed
VS Code #20191014.11 succeeded
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Oct 14, 2019

Thanks! Will be in the next insiders build and is scheduled to go out with VS Code 1.40

@MartinBrathen

This comment has been minimized.

Copy link
Contributor Author

MartinBrathen commented Oct 15, 2019

Cool! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.