Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove TypeScript from ExtensionSuggestions #82125

merged 2 commits into from Oct 8, 2019


Copy link

jsjoeio commented Oct 8, 2019

This PR resolves #82053


  • removes (comment out) the TypeScript section on the Welcome Page


Screen Shot 2019-10-08 at 2 56 09 PM

Additional Context

Originally, the Welcome page suggested users working with TypeScript install the TSLint extension. However, the TSLint extension is being deprecated in favor of ESLint. Instead of recommending ESLint, @mjbvz suggested dropping the TypeScript section altogether for now.

@@ -146,7 +146,7 @@ interface ExtensionSuggestion {

const extensionPacks: ExtensionSuggestion[] = [
{ name: localize('welcomePage.javaScript', "JavaScript"), id: 'dbaeumer.vscode-eslint' },
{ name: localize('welcomePage.typeScript', "TypeScript"), id: 'ms-vscode.vscode-typescript-tslint-plugin' },
// { name: localize('welcomePage.typeScript', "TypeScript"), id: 'ms-vscode.vscode-typescript-tslint-plugin' },

This comment has been minimized.

Copy link

mjbvz Oct 8, 2019


Can you please just delete this line instead. No reason to keep it around

This comment has been minimized.

Copy link

jsjoeio Oct 8, 2019

Author Contributor

Sure thing!

@mjbvz mjbvz added this to the October 2019 milestone Oct 8, 2019
@mjbvz mjbvz merged commit 90b66c8 into microsoft:master Oct 8, 2019
1 of 2 checks passed
1 of 2 checks passed
VS Code in progress
license/cla All CLA requirements met.

This comment has been minimized.

Copy link

mjbvz commented Oct 8, 2019


@jsjoeio jsjoeio deleted the jsjoeio:jsjoeio/remove-ts-welcome branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.