Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the problem of overwriting many characters in suggestion #82349

Merged
merged 1 commit into from Oct 11, 2019

Conversation

@yamachu
Copy link
Contributor

yamachu commented Oct 11, 2019

This PR fixes #82324

No test code...

vscode-fix

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Oct 11, 2019

This looks like the right fix for me. It seems to have been an oversight by @jrieken in fcd4e09 to switch from editorPosition to position.

@jrieken When I test the PR, everything seems to work OK so I'll merge it such that we get the fix early Monday morning.

@joaomoreno joaomoreno merged commit a698117 into microsoft:master Oct 11, 2019
2 checks passed
2 checks passed
VS Code #20191011.16 succeeded
Details
license/cla All CLA requirements met.
@jrieken

This comment has been minimized.

Copy link
Member

jrieken commented Oct 14, 2019

Thanks everyone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.