Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open New Terminal -> Open New External Terminal #82380

Merged
merged 2 commits into from Oct 14, 2019

Conversation

@solomatov
Copy link
Contributor

solomatov commented Oct 11, 2019

Open New Terminal command palette action is confusing since people expect it to open internal terminal, but it opens external terminal instead. I changed the title to make it less confusing.

Also, what do you think about assigning it to Cmd+Shift+` on the Mac so that we have some kind of uniformity in shortcuts?

Copy link
Member

Tyriar left a comment

👎 to adding cmd+shift+ since ctrl+shift+ is a companion to ctrl+, and cmd+ can't be added as it's an OS-level keybinding.

@Tyriar Tyriar added this to the October 2019 milestone Oct 14, 2019
@Tyriar
Tyriar approved these changes Oct 14, 2019
Copy link
Member

Tyriar left a comment

Thanks!

@Tyriar Tyriar merged commit 8447937 into microsoft:master Oct 14, 2019
2 checks passed
2 checks passed
VS Code #20191011.75 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.