Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #82200 - "Preserve Case" button in search viewlet is not tabbable #82485

Merged
merged 3 commits into from Oct 23, 2019

Conversation

@skprabhanjan
Copy link
Contributor

skprabhanjan commented Oct 14, 2019

@roblourens , Added the tab functionality for the preserve case button in order to fix #82200.

Whatever onRegexKeyDown was doing before is now being done in onPreserveCaseKeyDown and onRegexKeyDown only makes the preserve case to get focussed.

@joaomoreno joaomoreno removed their assignment Oct 14, 2019
Copy link
Member

roblourens left a comment

Great, except tabbing backwards (shift+tab) needs to work too.

@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

skprabhanjan commented Oct 16, 2019

@roblourens , Sorry forgot to add that part but it is taken care now , Please check :)

@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Oct 16, 2019

Ok now if the replace input is collapsed, I can't shift+tab past the details ... button, I get stuck there.

@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

skprabhanjan commented Oct 22, 2019

@roblourens . Fixed this and sorry for the delay :)

@roblourens roblourens added this to the October 2019 milestone Oct 23, 2019
@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Oct 23, 2019

Thanks!

@roblourens roblourens merged commit 8ab2f99 into microsoft:master Oct 23, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191022.23 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.