Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pin close others #82545

Merged
merged 2 commits into from Oct 15, 2019

Conversation

@NRauh
Copy link
Contributor

NRauh commented Oct 15, 2019

Currently when someone selects 'Close Others' on an unpinned editor, the editor remains unpinned.

That behavior seemed inconsistent to me since moving an editor around in a group or to a new group pins it. I think it makes sense that if someone is saying to close all editors apart from one, that the one editor should be pinned.

I also made it so an editor is pinned if someone selects 'Close to the right', but I'm less sure of that behavior. If this behavior remains, does it make sense to pin any unpinned editors to the left?

I don't have a problem adding tests, but I didn't see where the relevant tests were.

Here's the new behavior
close others vscode

@bpasero bpasero merged commit 11daba9 into microsoft:master Oct 15, 2019
2 checks passed
2 checks passed
VS Code #20191015.3 succeeded
Details
license/cla All CLA requirements met.
@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Oct 15, 2019

makes sense 👍

@bpasero bpasero added this to the October 2019 milestone Oct 15, 2019
@NRauh NRauh deleted the NRauh:feature/pin-close-others branch Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.