Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 30419 and 80649 - Allow Setting the Number of Recent Tasks #82757

Merged
merged 6 commits into from Oct 21, 2019

Conversation

@hypercubestart
Copy link
Contributor

hypercubestart commented Oct 17, 2019

This PR fixes #30419 and #80649

This creates a new setting section called quickOpen under Features and allows the user to specify the number of recent tasks in the quick open history to keep track of.

Not sure if it was a good idea to add a default parameter to the LRUCache set method, but it was the cleanest and quickest way to keep the ordering of the quick open tasks from most recent - least recent while using an LRUCache.

@hypercubestart hypercubestart changed the title Fix 30419 and 80649 Fix 30419 and 80649 - Allow Setting the Number of Recent Tasks Oct 17, 2019
@alexr00 alexr00 added this to the October 2019 milestone Oct 18, 2019
@alexr00 alexr00 self-requested a review Oct 18, 2019
Copy link
Member

alexr00 left a comment

Thanks for the PR! Just a few changes then we'll be good to go.

@hypercubestart hypercubestart force-pushed the hypercubestart:fix-30419 branch from edfc774 to cdb6d34 Oct 18, 2019
@hypercubestart hypercubestart requested a review from alexr00 Oct 18, 2019
@hypercubestart

This comment has been minimized.

Copy link
Contributor Author

hypercubestart commented Oct 21, 2019

@alexr00 Can you please review this PR again? Thank you!

Copy link
Member

alexr00 left a comment

Looks good, thank you for taking on this change and finishing it!

@alexr00 alexr00 merged commit 6bba03b into microsoft:master Oct 21, 2019
2 checks passed
2 checks passed
VS Code #20191019.6 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.