Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for command line arguments in grunt task runner #82819

Merged
merged 1 commit into from Oct 18, 2019

Conversation

@sohailrajdev97
Copy link
Contributor

sohailrajdev97 commented Oct 18, 2019

This PR fixes #66748

This PR adds the support to pass task arguments from grunt task runner extension. I have created a sample repository (as suggested by @alexr00) for checking the functionality here. Steps to check the functionality:

  1. Clone the repository
  2. Install the dependencies using npm install
  3. Build vscode with this added functionality
  4. Test the task which has been defined in tasks.json of the sample repository. This task passes a command line argument to the task runner
@alexr00 alexr00 self-assigned this Oct 18, 2019
@alexr00 alexr00 self-requested a review Oct 18, 2019
Copy link
Member

alexr00 left a comment

Nice change! Looks like you also fixed a bug. Thanks for the sample repository, it made it quick and easy to test this.

@alexr00 alexr00 merged commit e10218c into microsoft:master Oct 18, 2019
2 checks passed
2 checks passed
VS Code #20191018.9 succeeded
Details
license/cla All CLA requirements met.
Details
@alexr00 alexr00 added this to the October 2019 milestone Oct 18, 2019
@sohailrajdev97 sohailrajdev97 deleted the sohailrajdev97:grunt-args branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.