Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clear button to settings editor search bar #82904

Merged

Conversation

@smilegodly
Copy link

smilegodly commented Oct 19, 2019

I added a clear button to the settings editor search bar...
This clear button works the same as the one in the keyboard shortcuts editor, it clears the input that is in the search bar and then refocuses.

image

This is helpful if you want to clear the search bar while browsing results as the clear search option that is currently implemented doesn't pop up on search results. The button saves the extra step of having to backspace and retype your search as its just 1 click that does this.

This PR fixes #66141

@msftclas

This comment has been minimized.

Copy link

msftclas commented Oct 19, 2019

CLA assistant check
All CLA requirements met.

@smilegodly smilegodly force-pushed the smilegodly:clearButtonForSettingsEditor branch 2 times, most recently from 38383fd to 27cebbc Oct 19, 2019
Resolves #66141
@roblourens roblourens self-assigned this Oct 20, 2019
@smilegodly smilegodly force-pushed the smilegodly:clearButtonForSettingsEditor branch from 27cebbc to 1fc990a Oct 21, 2019
Copy link
Member

roblourens left a comment

Looks great, thanks!

@roblourens roblourens added this to the October 2019 milestone Oct 23, 2019
@roblourens roblourens merged commit f5d3ffa into microsoft:master Oct 23, 2019
2 checks passed
2 checks passed
VS Code #20191021.49 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.