Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out dead keys in tree keyboard navigation #82972

Merged
merged 1 commit into from Oct 21, 2019

Conversation

@frobinsonj
Copy link
Contributor

frobinsonj commented Oct 21, 2019

Fixes #80741

Steps to reproduce original issue:

  1. Set keyboard layout to Portuguese
  2. Put focus on explorer section
  3. Press one of the following keys:
  • ^
  • ´
  • `
  • ~

This PR should prevent these key presses from outputting 'Dead' in the tree keyboard navigation.

Fixes #80741
@joaomoreno joaomoreno merged commit cfb88f2 into microsoft:master Oct 21, 2019
2 checks passed
2 checks passed
VS Code #20191021.18 succeeded
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Oct 21, 2019

Thanks! 🍻

@joaomoreno joaomoreno added this to the October 2019 milestone Oct 21, 2019
@joaomoreno joaomoreno added the tree label Oct 21, 2019
@frobinsonj frobinsonj deleted the frobinsonj:fix-80741 branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.