Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: only run on master branch #83158

Merged
merged 3 commits into from Oct 24, 2019

Conversation

@ethomson
Copy link
Contributor

ethomson commented Oct 23, 2019

At present, GitHub Actions is configured to build on every pull request and push to any branch.

This means that CI runs will run in duplicate for pull requests that originate from branches in the repository (ie, those not from a fork). That is to say: if you push a branch foo and then open a pull request from foo to master, you'll see duplicate builds, one for the push into foo and one for the pull request into master.

By limiting this to pushes to master and pull_requests to master, this will remove the dual build problem.

/cc @joaomoreno

@ethomson

This comment has been minimized.

Copy link
Contributor Author

ethomson commented Oct 23, 2019

Should I include other branches, like release branches here?

@joaomoreno joaomoreno added this to the October 2019 milestone Oct 23, 2019
@joaomoreno joaomoreno self-assigned this Oct 23, 2019
ethomson and others added 2 commits Oct 23, 2019
Co-Authored-By: João Moreno <mail@joaomoreno.com>
Co-Authored-By: João Moreno <mail@joaomoreno.com>
@ethomson

This comment has been minimized.

Copy link
Contributor Author

ethomson commented Oct 23, 2019

Thanks @joaomoreno - that's exactly the syntax. I've pulled in those changes.

@joaomoreno joaomoreno merged commit 200d66a into microsoft:master Oct 24, 2019
1 of 5 checks passed
1 of 5 checks passed
linux linux
Details
windows windows
Details
darwin darwin
Details
VS Code #20191023.99 failed
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.