Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Change terminal link hover widget position to be consistent #83175
Currently, the tooltip position is where the mouse position is, and it sometimes creates unexpected behaviors.
With the pull request, the tooltip position is based on where the link position is.
To do this, I had to change the terminalWidgetManager to render Widgets using bottom position, since the terminal is snapped to the bottom of the container and has no knowledge about the extra space at the top between the actual terminal and the container. Since link tooltips are the only thing I found that uses the terminalWidgetManager, I figured it would be okay. I also added a new parameter that controls whether or not the bottom position is to the top or bottom of the widget.
I tested it for both renderers and with increased letter spacing and line heights.