Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Reveal in Explorer" to "Reveal in Side Bar" on Search result filename context menu #83418

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented Oct 28, 2019

This PR fixes #83139 as discussed there. The context menu option on a Search result filename that was previously captioned 'Reveal in Explorer' is now captioned 'Reveal in Side Bar'

@gjsjohnmurray gjsjohnmurray changed the title Resolve https://github.com/microsoft/vscode/issues/83139 Rename "Reveal in Explorer" to "Reveal in Side Bar" on Search result filename context menu Oct 28, 2019
@gjsjohnmurray

This comment has been minimized.

Copy link
Contributor Author

gjsjohnmurray commented Oct 30, 2019

I don't understand the CI failures on windows and darwin. Is there a way to resubmit in case they were transient?

@gjsjohnmurray

This comment has been minimized.

Copy link
Contributor Author

gjsjohnmurray commented Nov 1, 2019

Judging by this item in the 1.40 release notes, the built-in Git extension should probably also have its new 'Reveal in Explorer' menu action recaptioned 'Reveal in Sidebar'

@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Nov 11, 2019

Sorry for the slow response, I was on vaction.
I am fine with this change. However I would leave it up to @roblourens and @JacksonKearl since they own the search experience.

@isidorn isidorn assigned roblourens and JacksonKearl and unassigned isidorn Nov 11, 2019
@roblourens

This comment has been minimized.

Copy link
Member

roblourens commented Nov 11, 2019

FYI @joaomoreno

Judging by this item in the 1.40 release notes, the built-in Git extension should probably also have its new 'Reveal in Explorer' menu action recaptioned 'Reveal in Sidebar'

@roblourens roblourens added this to the November 2019 milestone Nov 11, 2019
@roblourens roblourens merged commit e54bf8c into microsoft:master Nov 11, 2019
2 of 5 checks passed
2 of 5 checks passed
linux
Details
windows windows
Details
darwin darwin
Details
VS Code #20191028.26 failed
Details
license/cla All CLA requirements met.
@gjsjohnmurray

This comment has been minimized.

Copy link
Contributor Author

gjsjohnmurray commented Nov 20, 2019

Judging by this item in the 1.40 release notes, the built-in Git extension should probably also have its new 'Reveal in Explorer' menu action recaptioned 'Reveal in Sidebar'

Fixed by 3bf8e81

@gjsjohnmurray gjsjohnmurray deleted the gjsjohnmurray:fix-83139 branch Nov 20, 2019
@joaomoreno joaomoreno added bug ux and removed bug ux labels Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.