Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of relative paths for git.ignoredRepositories #83466

Merged
merged 2 commits into from Nov 29, 2019

Conversation

@Wowol
Copy link
Contributor

Wowol commented Oct 28, 2019

This PR fixes #76892

@joaomoreno joaomoreno added the git label Oct 29, 2019
@Wowol Wowol force-pushed the Wowol:issue-76892 branch 2 times, most recently from 3a51078 to a7c73af Oct 29, 2019
@Wowol Wowol force-pushed the Wowol:issue-76892 branch from a7c73af to a9ac61f Oct 29, 2019
@Wowol

This comment has been minimized.

Copy link
Contributor Author

Wowol commented Oct 29, 2019

@joaomoreno You were right, converting the path into a URI and then getting its fsPath is breaking path on Linux, so I've removed it. Pull request is ready to be merged now :)

@Wowol

This comment has been minimized.

Copy link
Contributor Author

Wowol commented Nov 14, 2019

@joaomoreno Is there anything wrong with this PR? I'm not sure why it isn't merged yet, and I don't want conflicts to appear in future due to further changes.
If I can help with something, please let me know.

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 29, 2019

Thanks! 🎆

@joaomoreno joaomoreno merged commit 0fb5275 into microsoft:master Nov 29, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191029.46 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.