Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to electron 7.x #83796

Merged
merged 18 commits into from Jan 9, 2020
Merged

chore: Upgrade to electron 7.x #83796

merged 18 commits into from Jan 9, 2020

Conversation

@deepak1556
Copy link
Contributor

deepak1556 commented Oct 31, 2019

Chromium: 78.0.3904.130
Nodejs: 12.8.1
Electron: 7.1.7

@deepak1556 deepak1556 added this to the November 2019 milestone Oct 31, 2019
@deepak1556 deepak1556 self-assigned this Oct 31, 2019
@deepak1556 deepak1556 requested a review from bpasero Oct 31, 2019
@deepak1556 deepak1556 force-pushed the electron-7.0.x branch 5 times, most recently from 8b1d30d to 5a658f0 Nov 1, 2019
@deepak1556 deepak1556 marked this pull request as ready for review Nov 2, 2019
@bpasero
bpasero approved these changes Nov 2, 2019
Copy link
Member

bpasero left a comment

Changes LGTM but I suggest this timeline:

  • consistent green CI builds on all platforms
  • green exploration build for selfhosting during this milestone
  • full endgame testing on all platforms on exploration build (including dev setup)
  • push to insiders next milestone if no blockers
@@ -366,15 +366,13 @@ export class ElectronMainService implements IElectronMainService {
//#region Connectivity

async resolveProxy(windowId: number | undefined, url: string): Promise<string | undefined> {

This comment has been minimized.

Copy link
@ZuBB

ZuBB Nov 4, 2019

(maybe I am missing smth, but still..) Is current version of return type still valid after change that is below?

@deepak1556 deepak1556 force-pushed the electron-7.0.x branch from 20ab677 to 22c3db0 Dec 3, 2019
@webczat

This comment has been minimized.

Copy link

webczat commented Dec 28, 2019

What prevents this to be merged? It is required for linux accessibility so I am waiting impatiently...

@Tyriar Tyriar modified the milestones: November 2019, January 2020 Jan 6, 2020
@deepak1556 deepak1556 merged commit 4c7431c into master Jan 9, 2020
6 checks passed
6 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20200109.38 succeeded
Details
VS Code Distro Sync & Merge Check #20200109.25 succeeded
Details
license/cla All CLA requirements met.
Details
@deepak1556 deepak1556 deleted the electron-7.0.x branch Jan 9, 2020
@@ -13,7 +13,7 @@ const webviewId = 'myWebview';

const testDocument = join(vscode.workspace.rootPath || '', './bower.json');

suite('Webview tests', () => {
suite.skip('Webview tests', () => {

This comment has been minimized.

Copy link
@mjbvz

mjbvz Jan 9, 2020

Contributor

Hey looks like web views are broken under electron due to Prevented webview attach. I'm looking into it but wonder if you have any idea what that may be?

This comment has been minimized.

Copy link
@mjbvz

mjbvz Jan 9, 2020

Contributor

Pushed fix with c8123de and re-enabled the tests

mjbvz added a commit that referenced this pull request Jan 9, 2020
Caused by #83796

Also re-enables the webview tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.