From 1e1a5c681707f94c9527843f532e8e4727584d0d Mon Sep 17 00:00:00 2001 From: SteVen Batten Date: Mon, 4 Nov 2019 10:18:22 -0800 Subject: [PATCH 1/2] fixes #83912 --- src/vs/editor/contrib/hover/hover.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/vs/editor/contrib/hover/hover.ts b/src/vs/editor/contrib/hover/hover.ts index e0e509f06f137..4b9f4da1dbd24 100644 --- a/src/vs/editor/contrib/hover/hover.ts +++ b/src/vs/editor/contrib/hover/hover.ts @@ -259,19 +259,19 @@ class ShowHoverAction extends EditorAction { } } -class ShowCtrlHoverAction extends EditorAction { +class ShowDefinitionPreviewHoverAction extends EditorAction { constructor() { super({ - id: 'editor.action.showCtrlHover', + id: 'editor.action.showDefinitionPreviewHover', label: nls.localize({ - key: 'showCtrlHover', + key: 'showDefinitionPreviewHover', comment: [ - 'Label for action that will trigger the showing of a ctrl+hover in the editor.', - 'This allows for users to show the ctrl+hover without using the mouse.' + 'Label for action that will trigger the showing of definition preview hover in the editor.', + 'This allows for users to show the ctrl/alt+hover without using the mouse.' ] - }, "Show Control Hover"), - alias: 'Show Control Hover', + }, "Show Definition Preview Hover"), + alias: 'Show Definition Preview Hover', precondition: undefined }); } @@ -302,7 +302,7 @@ class ShowCtrlHoverAction extends EditorAction { registerEditorContribution(ModesHoverController.ID, ModesHoverController); registerEditorAction(ShowHoverAction); -registerEditorAction(ShowCtrlHoverAction); +registerEditorAction(ShowDefinitionPreviewHoverAction); // theming registerThemingParticipant((theme, collector) => { From abbf9c2ae5344fa8120d16d4caa0863a646f3902 Mon Sep 17 00:00:00 2001 From: SteVen Batten Date: Mon, 4 Nov 2019 10:30:38 -0800 Subject: [PATCH 2/2] remove any mention of mod+hover --- src/vs/editor/contrib/hover/hover.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/editor/contrib/hover/hover.ts b/src/vs/editor/contrib/hover/hover.ts index 4b9f4da1dbd24..f39db5bbe4164 100644 --- a/src/vs/editor/contrib/hover/hover.ts +++ b/src/vs/editor/contrib/hover/hover.ts @@ -268,7 +268,7 @@ class ShowDefinitionPreviewHoverAction extends EditorAction { key: 'showDefinitionPreviewHover', comment: [ 'Label for action that will trigger the showing of definition preview hover in the editor.', - 'This allows for users to show the ctrl/alt+hover without using the mouse.' + 'This allows for users to show the definition preview hover without using the mouse.' ] }, "Show Definition Preview Hover"), alias: 'Show Definition Preview Hover',