Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor packaging issues in automation lib #83942

Merged
merged 5 commits into from Nov 7, 2019

Conversation

@jasongin
Copy link
Member

jasongin commented Nov 4, 2019

This PR fixes some minor issues that affected building and consumption of the automation library externally via an npm package:

  • Remove the postinstall npm script. This should not be run after installing the automation package because the npm package includes only the already-compiled output. And that script is not necessary for vscode smoketests because the smoke package runs yarn --cwd ../automation compile during its compilation.
  • Fix the driver module export in index.ts.
  • Add .npmignore
  • Update .gitignore

None of these changes should have any impact on building or running the vscode smoke tests. Anyway, I verified that the vscode smoke tests are still passing.

@jasongin

This comment has been minimized.

Copy link
Member Author

jasongin commented Nov 4, 2019

Tyriar added 2 commits Nov 4, 2019
@Tyriar Tyriar self-assigned this Nov 4, 2019
@Tyriar Tyriar added this to the October 2019 milestone Nov 4, 2019
test/automation/package.json Show resolved Hide resolved
@alexdima alexdima modified the milestones: October 2019, November 2019 Nov 6, 2019
@Tyriar
Tyriar approved these changes Nov 7, 2019
Copy link
Member

Tyriar left a comment

Works fine here 👍

@Tyriar

This comment has been minimized.

Copy link
Member

Tyriar commented Nov 7, 2019

Hmm, using && didn't used to work on Windows but it seems fine now in both Pipelines and Actions, guess that's fine.

@Tyriar Tyriar merged commit b73d1b4 into microsoft:master Nov 7, 2019
4 of 5 checks passed
4 of 5 checks passed
linux
Details
windows windows
Details
darwin
Details
VS Code #20191107.4 succeeded
Details
license/cla All CLA requirements met.
Details
@jasongin

This comment has been minimized.

Copy link
Member Author

jasongin commented Nov 7, 2019

Thanks!

@jasongin jasongin deleted the jasongin:automation-fixes branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.