Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes can't drag to select linkified text in the debug console #83956

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@jeanp413
Copy link
Contributor

jeanp413 commented Nov 5, 2019

This PR fixes #83264

classList.toggle return value is boolean, so when it returns false it cancels the onmousemove event making link text selection not possible.

@weinand weinand added the debug label Nov 5, 2019
@weinand weinand removed their assignment Nov 5, 2019
@weinand weinand added this to the November 2019 milestone Nov 5, 2019
@isidorn

This comment has been minimized.

Copy link
Contributor

isidorn commented Nov 12, 2019

Awesome find and great fix!

@isidorn isidorn merged commit 760957c into microsoft:master Nov 12, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191105.1 succeeded
Details
license/cla All CLA requirements met.
@jeanp413 jeanp413 deleted the jeanp413:fix-link-selection-debug-console branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.