Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Web Firefox: dropping a file onto itself navigates the page #83962

Merged
merged 1 commit into from Nov 5, 2019

Conversation

@jeanp413
Copy link
Contributor

jeanp413 commented Nov 5, 2019

This PR fixes #83287

@bpasero bpasero added this to the November 2019 milestone Nov 5, 2019
Copy link
Member

bpasero left a comment

@jeanp413 thanks, I think this is the right direction, but now thinking more about it, wouldn't the best fix be to prevent default on the workbench container where this event eventually bubbles up? As such I suggest this fix in:

private registerListeners(workbench: Workbench, storageService: BrowserStorageService): void {

// Prevent default navigation on drop
this._register(addDisposableListener(this.domElement, EventType.DROP, (e) => EventHelper.stop(e, true)));
@jeanp413 jeanp413 force-pushed the jeanp413:fix-83287 branch from 76a2c92 to 4efa950 Nov 5, 2019
@jeanp413

This comment has been minimized.

Copy link
Contributor Author

jeanp413 commented Nov 5, 2019

Much better. Thanks

@bpasero bpasero merged commit 5d3c599 into microsoft:master Nov 5, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191105.38 succeeded
Details
license/cla All CLA requirements met.
@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Nov 5, 2019

Thanks!

@jeanp413 jeanp413 deleted the jeanp413:fix-83287 branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.