Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builder-method for snippet choice #84048

Merged
merged 4 commits into from Nov 13, 2019

Conversation

@okmttdhr
Copy link
Contributor

okmttdhr commented Nov 6, 2019

This PR fixes #43643

@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 6, 2019

CLA assistant check
All CLA requirements met.

src/vs/workbench/api/common/extHostTypes.ts Outdated Show resolved Hide resolved
@jrieken jrieken added the snippets label Nov 7, 2019
@okmttdhr okmttdhr force-pushed the okmttdhr:snippet-choice-builder-method branch from fce5cc0 to 92b36ff Nov 9, 2019
@okmttdhr okmttdhr requested a review from jrieken Nov 9, 2019
Copy link
Member

jrieken left a comment

lgtm. thanks so far. one last thing that's left is to add the signature to the type in vscode.d.ts

Copy link
Member

jrieken left a comment

Looking good - one last thing: To expose this to extension authors, copy the new signature to the type declaration in vscode.d.ts, e.g here

appendVariable(name: string, defaultValue: string | ((snippet: SnippetString) => any)): SnippetString;

@jrieken jrieken added this to the November 2019 milestone Nov 9, 2019
@okmttdhr okmttdhr requested a review from jrieken Nov 10, 2019
@jrieken jrieken merged commit 0a0f2bf into microsoft:master Nov 13, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191110.1 succeeded
Details
license/cla All CLA requirements met.
Details
@okmttdhr okmttdhr deleted the okmttdhr:snippet-choice-builder-method branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.