Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix bug with hanged pseudoterminal #84181
@Tyriar It seems that finally I made the tests pass. Could you take a look? :-) Glad that you have the tests. When I made initial change, I didn't find them.
Also, what do you do if a build breaks. Is there a good way to clean everything? I have it all the time when I have yarn watch running, and change branches.
@Tyriar I also have a question for getting rid of delays in other place. There's this code:
Do I understand correctly that the else branch does nothing useful? The then block is activated only if the terminal is found, and the value returned by then has no side effects.
Will try review soon
Typically we don't need to do anything here as TypeScript is pretty good at handling this. If I do get into this state I'll either delete
I think that was to restart retrying maybe? That TODO is actually talking about how I proposed we fix this; create a bunch of promises and store their resolves instead of using polling.