Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt insert & replace in snippet provider #84206

Merged
merged 2 commits into from Nov 18, 2019

Conversation

@jeanp413
Copy link
Contributor

jeanp413 commented Nov 8, 2019

Fixes #83834

Fixes #83834
@jeanp413 jeanp413 force-pushed the jeanp413:adopt-insert-replace-snippets branch from 1e4059f to 8e91d73 Nov 15, 2019
@jeanp413

This comment has been minimized.

Copy link
Contributor Author

jeanp413 commented Nov 15, 2019

Updated the PR and added some unit tests. Let me know if more changes are needed

Copy link
Member

jrieken left a comment

Looking good. Optionally, use the endsWith-util instead of the commonPrefixLength trick, otherwise I'll merge on Monday

@jrieken jrieken added this to the November 2019 milestone Nov 15, 2019
@jeanp413

This comment has been minimized.

Copy link
Contributor Author

jeanp413 commented Nov 16, 2019

Do you mean startsWith right? I pushed a change for that

@jrieken jrieken merged commit 5abb877 into microsoft:master Nov 18, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191116.5 succeeded
Details
license/cla All CLA requirements met.
Details
@jeanp413 jeanp413 deleted the jeanp413:adopt-insert-replace-snippets branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.