Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #83940 #84414

Merged
merged 10 commits into from Nov 12, 2019
Merged

Fix #83940 #84414

merged 10 commits into from Nov 12, 2019

Conversation

@hadzhiyski
Copy link
Contributor

hadzhiyski commented Nov 10, 2019

Supported languages: de, en, es, fr, hu, it, pt-br, ru

This PR fixes #83940

Supported languages: de, en, es, fr, hu, it, pt-br, ru
@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 10, 2019

CLA assistant check
All CLA requirements met.

build/win32/i18n/messages.en.isl Outdated Show resolved Hide resolved
Co-Authored-By: jaqra <48099350+jaqra@users.noreply.github.com>
@jaqra

This comment has been minimized.

Copy link
Contributor

jaqra commented Nov 11, 2019

SourceFile=%1 Kaynak Dosyası

You can add

OpenWithCodeContextMeny=%1 İle Aç

But i am not sure which key must be set as shortkey

@hadzhiyski

This comment has been minimized.

Copy link
Contributor Author

hadzhiyski commented Nov 11, 2019

SourceFile=%1 Kaynak Dosyası

You can add

OpenWithCodeContextMeny=%1 İle Aç

But i am not sure which key must be set as shortkey

Thanks. I will try to research what is the correct translation for all supported languages

@jaqra

This comment has been minimized.

Copy link
Contributor

jaqra commented Nov 11, 2019

It is correct. It is my main language. You can also see from

AddContextMenuFiles=Windows Gezgini bağlam menüsüne "%1 İle Aç" eylemini ekle

build/win32/i18n/messages.ru.isl Outdated Show resolved Hide resolved
Copy link
Member

joaomoreno left a comment

Yeah, like @jaqra mentions, please fix the encoding issues. 👍 Thanks for the PR!

hadzhiyski added 3 commits Nov 11, 2019
@hadzhiyski

This comment has been minimized.

Copy link
Contributor Author

hadzhiyski commented Nov 11, 2019

Translations are added for all supported languages and the encoding issues are fixed. Please review

Copy link
Member

joaomoreno left a comment

@hadzhiyski I still see a lot of changes which don't make sense. Are you maybe converting line endings?

@hadzhiyski

This comment has been minimized.

Copy link
Contributor Author

hadzhiyski commented Nov 11, 2019

Is that what you mean? I deleted the empty lines on end of files, because that was the original look of the files. I added them now. Perhaps I do not have proper file formatting settings and I am really sorry about this and I will fix it. It is my first PR in vscode repository.

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 11, 2019

Not yet... Notice here, all these lines are marked as changed, yet there is no reason for you to have changed them. There must still be some line-ending/encoding change:

image

build/win32/i18n/messages.de.isl Outdated Show resolved Hide resolved
@hadzhiyski hadzhiyski requested a review from joaomoreno Nov 12, 2019
@joaomoreno joaomoreno added this to the November 2019 milestone Nov 12, 2019
@joaomoreno joaomoreno merged commit 72da3e4 into microsoft:master Nov 12, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191112.36 succeeded
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 12, 2019

Great job, thanks!

@hadzhiyski

This comment has been minimized.

Copy link
Contributor Author

hadzhiyski commented Nov 12, 2019

Thank you all for the support

@hadzhiyski hadzhiyski deleted the hadzhiyski:vh/83940-open-with-i18n branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.