Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show JS/TS References Code Lens for Inner Functions #84689

Merged
merged 5 commits into from Nov 23, 2019

Conversation

@okmttdhr
Copy link
Contributor

okmttdhr commented Nov 13, 2019

This PR fixes #22981

@okmttdhr okmttdhr changed the title WIP Show JS/TS References Code Lens for Inner Functions Show JS/TS References Code Lens for Inner Functions Nov 13, 2019
@okmttdhr okmttdhr marked this pull request as ready for review Nov 13, 2019
@okmttdhr okmttdhr requested a review from mjbvz Nov 14, 2019
@okmttdhr okmttdhr force-pushed the okmttdhr:inner-function-code-lens branch from 12b4faa to 1d7d80b Nov 16, 2019
@okmttdhr okmttdhr force-pushed the okmttdhr:inner-function-code-lens branch from f7d1a8a to 6f20e9e Nov 22, 2019
@okmttdhr okmttdhr requested a review from mjbvz Nov 22, 2019
@okmttdhr okmttdhr requested a review from mjbvz Nov 23, 2019
@mjbvz mjbvz added this to the November 2019 milestone Nov 23, 2019
@mjbvz mjbvz merged commit 0db887a into microsoft:master Nov 23, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191123.2 succeeded
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Nov 23, 2019

Thanks! Will be in next insiders build

@okmttdhr okmttdhr deleted the okmttdhr:inner-function-code-lens branch Nov 23, 2019
@tomillie

This comment has been minimized.

Copy link

tomillie commented Dec 13, 2019

I now have references almost on every line. Was that intended?

image

@okmttdhr

This comment has been minimized.

Copy link
Contributor Author

okmttdhr commented Dec 17, 2019

@tomillie
I think this is not related to this PR.

We need to add a new setting around here (or show references not for every property).
https://github.com/okmttdhr/vscode/blob/ec20ba205cee4b63e6162ae551d3ca9e19f53dda/extensions/typescript-language-features/src/features/referencesCodeLens.ts#L92-L96

@tomillie

This comment has been minimized.

Copy link

tomillie commented Dec 18, 2019

It's been fixed.
#86495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.