Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make local and remote ports configurable #84958

Merged
merged 6 commits into from Nov 18, 2019
Merged

Conversation

@SoraKumo001
Copy link
Contributor

SoraKumo001 commented Nov 16, 2019

Modification to enable handling in cases where local port and remote port are different

#RemotePort=30000 LocalPort=8080
yarn web --port=30000 --local_port=8080

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Nov 18, 2019

What is the scenario to support here?

@SoraKumo001

This comment has been minimized.

Copy link
Contributor Author

SoraKumo001 commented Nov 18, 2019

When vscode-web was tested on vscode-online, there was a difference between the local port number and the remote address port to check from the browser during execution.
At this time, the script address output from vscode-web to the browser indicates the local port, causing a problem in operation.
This content is to deal with it.

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Nov 18, 2019

Could this be documented somehow in the args?

@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Nov 18, 2019

Something like showing help output when running "yarn web --help"

@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 18, 2019

CLA assistant check
All CLA requirements met.

Copy link
Member

bpasero left a comment

Thanks for doing this, some feedback provided.

server.listen(PORT, () => {
console.log(`Web UI available at ${SCHEME}://${AUTHORITY}`);
server.listen(LOCAL_PORT, () => {
console.log(`Operating location at http://0.0.0.0:${LOCAL_PORT}`);

This comment has been minimized.

Copy link
@bpasero

bpasero Nov 18, 2019

Member

I would only print this if the local port is different from the remote? Otherwise a bit confusing

if(args.help){
console.log(
'yarn web [options]\n' +
' --no-launch Launch browser\n' +

This comment has been minimized.

Copy link
@bpasero

bpasero Nov 18, 2019

Member

I think the text is wrong, if specified this does not launch the browser, right?

console.log(
'yarn web [options]\n' +
' --no-launch Launch browser\n' +
' --scheme Potocol\n' +

This comment has been minimized.

Copy link
@bpasero

bpasero Nov 18, 2019

Member

Maybe Protocol (https or http)

@bpasero bpasero added this to the November 2019 milestone Nov 18, 2019
@bpasero bpasero added web and removed needs more info labels Nov 18, 2019
SoraKumo001 added 2 commits Nov 18, 2019
Changed to show additional message only when local port is changed.
@bpasero bpasero merged commit 7021e20 into microsoft:master Nov 18, 2019
3 of 5 checks passed
3 of 5 checks passed
linux
Details
windows
Details
darwin darwin
Details
VS Code in progress
Details
license/cla All CLA requirements met.
Details
@bpasero

This comment has been minimized.

Copy link
Member

bpasero commented Nov 18, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.