Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to git hook (dev qol) #85159

Merged
merged 3 commits into from Nov 29, 2019
Merged

Conversation

@anthonydresser
Copy link
Member

anthonydresser commented Nov 19, 2019

Currently the git hook takes every change you have and starts the filter from there and bypasses the "all" filter.

This changes it so the files from the git hook are filtered through "all" first.

I considered adding the filter at https://github.com/microsoft/vscode/blob/master/build/gulpfile.hygiene.js#L332 instead, but this seems like a more targeted fix.

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 28, 2019

Actually, since one can also invoke gulpfile.hygiene.js as a standalone script, it would be better to have the fix up there instead, such that files passed in such a way also run through the all filter. What do you think?

@anthonydresser

This comment has been minimized.

Copy link
Member Author

anthonydresser commented Nov 28, 2019

I was also thinking that, but I wasn't sure if there was a scenario where we would want to just hygiene exactly what the caller passed (i.e it was intentional to pass in a file not listed by the all filter). But I generally agree that it would make more sense just to filter everything that goes through hygiene.

@anthonydresser

This comment has been minimized.

Copy link
Member Author

anthonydresser commented Nov 28, 2019

@joaomoreno I've updated it to filter everything passed into the hygiene task, let me know what you think.

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 29, 2019

Excellent, thanks! 🎆

@joaomoreno joaomoreno added this to the November 2019 milestone Nov 29, 2019
@joaomoreno joaomoreno merged commit b157e4d into microsoft:master Nov 29, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191128.34 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.