Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appRoot to windows protocol handler for dev #85289

Merged

Conversation

@jzyrobert
Copy link
Contributor

jzyrobert commented Nov 21, 2019

This PR fixes #85046

If isBuilt is false, environmentService.appRoot will be added to the arguments such that electron will be able to find the app.

@jzyrobert

This comment has been minimized.

Copy link
Contributor Author

jzyrobert commented Nov 21, 2019

However, this seems to fail when your path to the vscode folder contains spaces.
E.g. User/me/Documents/My Work/vscode
Would this require to be wrapped in quotes or escaped?

@jzyrobert jzyrobert force-pushed the jzyrobert:85046_windows_protocol_handler branch from 87ca2cf to b8ecf87 Nov 21, 2019
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 22, 2019

@jzyrobert I see you already added quotes around the path. That doesn't address the issue?

@joaomoreno joaomoreno changed the title Add appRoot to windows protocol handler Add appRoot to windows protocol handler for dev Nov 22, 2019
@jzyrobert

This comment has been minimized.

Copy link
Contributor Author

jzyrobert commented Nov 22, 2019

@joaomoreno I pushed the quotes after my previous comment (it works), is that fine?

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 22, 2019

Nice, thanks!

@joaomoreno joaomoreno added this to the November 2019 milestone Nov 28, 2019
@joaomoreno joaomoreno merged commit 17f381f into microsoft:master Nov 28, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191121.44 succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.