Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't encode image resource URI twice #85355

Merged

Conversation

@jeanp413
Copy link
Contributor

jeanp413 commented Nov 22, 2019

After #84667 and 8caf39e, issue #84197 and #83165 are happening again.

This fixes both issues by encoding the resource URI just once so that it gets parsed correctly here

This PR fixes #84197 and #83165

cc @mjbvz

@mjbvz mjbvz added this to the November 2019 milestone Nov 22, 2019
@mjbvz mjbvz merged commit 56a544b into microsoft:master Nov 22, 2019
5 checks passed
5 checks passed
linux
Details
windows
Details
darwin
Details
VS Code #20191122.3 succeeded
Details
license/cla All CLA requirements met.
@mjbvz

This comment has been minimized.

Copy link
Contributor

mjbvz commented Nov 22, 2019

Thanks!

@jeanp413 jeanp413 deleted the jeanp413:fix-webview-image-name-special-char branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.