Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent path to git clone command #85459

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@vially
Copy link
Contributor

vially commented Nov 23, 2019

This PR fixes #85458 by adding another argument for the parent directory to the git.clone command (see #85458 for more details about the use-case that this pull-request is trying to address)

@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 23, 2019

CLA assistant check
All CLA requirements met.

@joaomoreno joaomoreno added the git label Nov 25, 2019
@joaomoreno joaomoreno added this to the November 2019 milestone Nov 28, 2019
@joaomoreno joaomoreno merged commit f8b2bb8 into microsoft:master Nov 28, 2019
4 checks passed
4 checks passed
linux
Details
windows
Details
darwin
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 28, 2019

Thanks! 🎆

@vially vially deleted the vially:git-clone-dest-path branch Nov 28, 2019
if (!parentPath) {
const config = workspace.getConfiguration('git');
let defaultCloneDirectory = config.get<string>('defaultCloneDirectory') || os.homedir();
defaultCloneDirectory = defaultCloneDirectory.replace(/^~/, os.homedir());

This comment has been minimized.

Copy link
@connor4312

connor4312 Dec 3, 2019

Member

We may want to do this for provided parent paths as well; currently running a command to clone into ~/Github displays an error @joaomoreno

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.